Improve page-test command's failure-handling + reporting #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jeremyh
commented
Mar 24, 2021
•
jeremyh
commented
- The failure limit should be based on consecutive errors, rather than total. This is more useful as the purpose of the failure limit is to stop hitting services that are constantly failing.
- Add a throttle feature to sleep between requests.
- Print a failure count at the end.
- Show really slow requests as red
A few minor improvements to the page test. - Failure limit should be based on consecutive errors, rather than total. This is more useful as its purpose is to stop hitting services that are constantly failing. - Add a throttle feature to sleep between requests. - Say a failure count at the end.
Codecov Report
@@ Coverage Diff @@
## develop #272 +/- ##
===========================================
- Coverage 87.40% 87.07% -0.34%
===========================================
Files 24 24
Lines 2819 2832 +13
===========================================
+ Hits 2464 2466 +2
- Misses 355 366 +11
Continue to review full report at Codecov.
|
jeremyh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.