Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix build) Support for geoalchemy-2 0.9.0 #288

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

jeremyh
Copy link
Collaborator

@jeremyh jeremyh commented Jun 18, 2021

Earlier releases of geoalchemy returned Box2D types as strings, but the new 0.9 release returns them as complex Geometries, and which has broken our Stac api.

This PR adds an explicit cast to string so that we get the same type back from all versions of geoalchemy-2.

Earlier releases of geoalchemy returned Box2D types as strings, but the
new 0.9 release returns them as complex Geometries, and which has broken
our Stac api.

This PR adds an explicit cast to string so that we get the same type back
from all versions of geoalchemy-2.
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #288 (4174244) into develop (9d6d350) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #288   +/-   ##
========================================
  Coverage    86.75%   86.75%           
========================================
  Files           24       24           
  Lines         2952     2952           
========================================
  Hits          2561     2561           
  Misses         391      391           
Impacted Files Coverage Δ
cubedash/summary/_stores.py 92.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6d350...4174244. Read the comment docs.

@jeremyh jeremyh merged commit 9ccf624 into opendatacube:develop Jun 18, 2021
@jeremyh jeremyh deleted the geoalchemy2 branch June 18, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant