Move Docker image to the standard gdal base #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyh
changed the title
jeremyh
force-pushed
the
normal-gdal-docker
branch
from
6c30555 to
2827f87
Compare
jeremyh
commented
Oct 5, 2021
Comment on lines
-2
to
-4
| sqlalchemy==1.3.20 | ||
| click<8.0.0 | ||
| eodatasets3>=0.17.0 |
There was a problem hiding this comment.
There's appropriate minimum versions in the dependencies now, I believe. So I removed these.
It's less maintenance than the geo-base one (fixing the current scan issue), and brings us in-line with datacube-alchemist and eodatasets.
... and can't require an ODC config on build.
The test is broken on newer docker container -- built-in WKT strings are slightly different. Strangely, it was sorting ascending and picking the first. ... so the least good match? But this worked because the test data used a completely different capitalisation to the real CRS, so they didn't match at all. Changed them to: 1. Compare without case sensitivity. 2. Compare total matches, rather than ratio. WKTs are very diff. lengths, and we want to match their strings of names/numbers, not penalize for missing sections (which is common). 3. Pick the best match, not the least
jeremyh
force-pushed
the
normal-gdal-docker
branch
from
16e7d52 to
b86cd9b
Compare
Their dict return type changes too often. Suddenly our error messages are incorrect as we aren't looking for the right key names.
Codecov Report
@@ Coverage Diff @@
## develop #324 +/- ##
========================================
Coverage 86.18% 86.19%
========================================
Files 25 25
Lines 3048 3049 +1
========================================
+ Hits 2627 2628 +1
Misses 421 421
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's less maintenance than the geo-base one, and brings us in-line with datacube-alchemist and eodatasets.
It also fixes the current security-scan failure.