Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make grouping CRS configurable #328

Merged
merged 7 commits into from
Oct 14, 2021
Merged

Make grouping CRS configurable #328

merged 7 commits into from
Oct 14, 2021

Conversation

jeremyh
Copy link
Collaborator

@jeremyh jeremyh commented Oct 12, 2021 •
edited
Loading

Closes #206

  • A different CRS can be chosen on init of your Explorer schema: cubedash-gen --init --epsg 3577
  • If not specified, the default is now global equal-area epsg:6933 instead of Australian Albers.

@jeremyh jeremyh force-pushed the configurable-crs branch 2 times, most recently from d1970cc to 4803ab0 Compare October 12, 2021 00:56
@codecov
Copy link

codecov bot commented Oct 13, 2021 •
edited
Loading

Codecov Report

Merging #328 (57ac29b) into develop (bbba14c) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #328      +/-   ##
===========================================
- Coverage    86.19%   86.18%   -0.02%     
===========================================
  Files           25       25              
  Lines         3049     3061      +12     
===========================================
+ Hits          2628     2638      +10     
- Misses         421      423       +2
Impacted Files Coverage Δ
cubedash/summary/_summarise.py 96.05% <ø> (-0.20%) ⬇️
cubedash/generate.py 81.93% <50.00%> (+0.23%) ⬆️
cubedash/summary/_schema.py 81.51% <87.50%> (+0.09%) ⬆️
cubedash/summary/_stores.py 91.58% <91.66%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbba14c...57ac29b. Read the comment docs.

@jeremyh jeremyh force-pushed the configurable-crs branch 2 times, most recently from bbe15e6 to 7a3fb4e Compare October 13, 2021 02:44
@jeremyh
EO3 tests should clean-up previous test db
9e09b49 
And don't forever-cache something we need to be reliably accurate to the
underlying DB. It's premature optimisation anyway.
@jeremyh jeremyh marked this pull request as ready for review October 13, 2021 08:59
@jeremyh jeremyh mentioned this pull request Oct 13, 2021
Closed
alexgleith
alexgleith approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@alexgleith alexgleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a GREAT change!

@jeremyh jeremyh merged commit a49d1c0 into opendatacube:develop Oct 14, 2021
@jeremyh jeremyh deleted the configurable-crs branch October 14, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgleith alexgleith alexgleith approved these changes

@uchchwhash uchchwhash Awaiting requested review from uchchwhash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footprint CRS is hardcoded
2 participants
@jeremyh @alexgleith