Embed the location in eo1 documents too #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From testing, ODC does support 'location' in eo1 documents. It makes indexing from Explorer much easier.
Codecov Report
@@ Coverage Diff @@
## develop #332 +/- ##
===========================================
+ Coverage 86.18% 86.22% +0.03%
===========================================
Files 25 25
Lines 3077 3077
===========================================
+ Hits 2652 2653 +1
+ Misses 425 424 -1
Continue to review full report at Codecov.
|
benjimin
added a commit
to opendatacube/datacube-wps
that referenced
this pull request
Jan 11, 2022
This relied on a recent ODC Explorer improvement, facilitating STAC indexing of older products (viz. mangroves), to maintain sample db rebuild capability. opendatacube/datacube-explorer#332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'location' field was added with eo3 so that we could record the original location in metadata.
But from testing, the location field works in EO1 documents too in ODC. So Explorer should include it there too.
This will make indexing from an Explorer instance easier, as the original location of the dataset will be preserved.