Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better timeline labeling #334

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Better timeline labeling #334

merged 1 commit into from
Oct 21, 2021

Conversation

jeremyh
Copy link
Collaborator

@jeremyh jeremyh commented Oct 20, 2021

new-timeline-labels

  • Always show the start and end as labels. This is useful to know at a glance.
  • Add an immediately-showing hover tooltip, similar to regions. Style it the same.
  • Remove all the middle labels, whose spacing and rarity was always a little weird. The tooltips are more useful.

@jeremyh
Timeline labeling improvement
db96d49 
Add an immediate tooltip, similar to regions. Style it the same

Always show the start and end as labels.

Remove all the middle labels, whose spacing was always a little weird
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #334 (db96d49) into develop (1ae0990) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #334   +/-   ##
========================================
  Coverage    86.22%   86.22%           
========================================
  Files           25       25           
  Lines         3077     3077           
========================================
  Hits          2653     2653           
  Misses         424      424

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae0990...db96d49. Read the comment docs.

@jeremyh jeremyh merged commit fea217d into opendatacube:develop Oct 21, 2021
@jeremyh jeremyh deleted the timeline-render branch December 6, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeremyh