Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Stac improvements #351

Merged
merged 10 commits into from
Jan 26, 2022
Merged

Minor Stac improvements #351

merged 10 commits into from
Jan 26, 2022

Conversation

jeremyh
Copy link
Collaborator

@jeremyh jeremyh commented Dec 9, 2021

Address some more edge cases allowed in Stac 1.0.0 and newer Stac API (beta) standards.

Will depend on the updates in opendatacube/eo-datasets#222 too.

(Relevant to #303)

[WIP]

  • Document/Test: Users should rerun --init to update their stac indexes (to fit with nullable geometry).

They add the deprecation warning and the replacement in
the same major version. So we can't fix deprecation warnings
without bumping our minimum.
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #351 (6177d39) into develop (1ec509b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6177d39 differs from pull request most recent head 6994e38. Consider uploading reports for the commit 6994e38 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #351      +/-   ##
===========================================
- Coverage    86.47%   86.46%   -0.01%     
===========================================
  Files           25       25              
  Lines         3119     3117       -2     
===========================================
- Hits          2697     2695       -2     
  Misses         422      422              
Impacted Files Coverage Δ
cubedash/_stac.py 91.63% <ø> (ø)
cubedash/summary/_extents.py 91.83% <ø> (ø)
cubedash/summary/_schema.py 81.51% <ø> (ø)
cubedash/summary/_stores.py 91.52% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec509b...6994e38. Read the comment docs.

@jeremyh jeremyh marked this pull request as ready for review January 26, 2022 22:42
@jeremyh jeremyh merged commit 6f861c3 into opendatacube:develop Jan 26, 2022
@jeremyh jeremyh deleted the stac1 branch January 26, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant