Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom error pages, fix js type error #357

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

jeremyh
Copy link
Collaborator

@jeremyh jeremyh commented Jan 12, 2022

Trivial, but we want to reduce noise.

.... also changed a right-margin to an even margin on the header nav, to be less surprisingl

Such as 404. We already have separate handling for
internal errors, and Stac API errors.
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #357 (92657af) into develop (7e7e82c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #357      +/-   ##
===========================================
+ Coverage    86.37%   86.39%   +0.01%     
===========================================
  Files           25       25              
  Lines         3090     3094       +4     
===========================================
+ Hits          2669     2673       +4     
  Misses         421      421              
Impacted Files Coverage Δ
cubedash/_pages.py 87.44% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e7e82c...92657af. Read the comment docs.

@jeremyh jeremyh marked this pull request as ready for review January 12, 2022 05:31
@jeremyh jeremyh changed the title Fix js type error on global menu close Add custom error pages, fix js type error Jan 12, 2022
@jeremyh jeremyh merged commit c06a550 into opendatacube:develop Jan 12, 2022
@jeremyh jeremyh deleted the visual-tweaks branch January 12, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant