Fix minor deployment warnings #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 seconds is a little too tight for API usage.
To clear the warning.
The traceback was coming from datasets with empty geometry collections. Moving to the non-deprecated alternative fixed the exception.
Codecov Report
@@ Coverage Diff @@
## develop #359 +/- ##
========================================
Coverage 86.44% 86.44%
========================================
Files 25 25
Lines 3107 3107
========================================
Hits 2686 2686
Misses 421 421
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings in the newer versions of Shapely and Sqlalchemy.
(There's still a couple of deprecation warnings coming from inside datacube-core's code, though. Already reported)
This also fixes the AttributeError coming from shapely during garbage collection. It was caused by the deprecated method not supporting empty geometry collections, which some datasets trigger. (I could reproduce it by viewing
wofs_summarydatasets on the NCI instance.)(Fixes #354)