-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make explorer to record region_code in metadata as first preference #394
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #394 +/- ##
========================================
Coverage 86.46% 86.46%
========================================
Files 25 25
Lines 3133 3133
========================================
Hits 2709 2709
Misses 424 424
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pin. This sounds like a good idea now that ingested products are mostly defunct.
We'll need to mention on release that this change can make affected products inconsistent (summaries could exist with both old regions and new regions depending on when they were generated).
People will need to --force
their summary update for those products to recreate all summaries consistently with the new regions.
noted! |
fix #342
if metadata provides region_code, that should be used directly, only if it's not offered, do the additional calculation.