Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make explorer to record region_code in metadata as first preference #394

Merged
merged 4 commits into from
Jun 16, 2022

Conversation

pindge
Copy link
Collaborator

@pindge pindge commented Jun 15, 2022

fix #342
if metadata provides region_code, that should be used directly, only if it's not offered, do the additional calculation.

  • add test case as raised by issue Incorrect tile numbers displayed for DEA C3 summary products #342, a case where metadata provides region_code and it displays correctly
  • add test case where the region is defined in the metadata but all are the same, explorer should still display the region as provided by the metadata, this will help expose issues during the development phase
  • add test case where the region is not defined in the metadata and explorer needs to calculate the tiles

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #394 (0d57534) into develop (1d8583f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #394   +/-   ##
========================================
  Coverage    86.46%   86.46%           
========================================
  Files           25       25           
  Lines         3133     3133           
========================================
  Hits          2709     2709           
  Misses         424      424           
Impacted Files Coverage Δ
cubedash/summary/_extents.py 91.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8583f...0d57534. Read the comment docs.

@pindge pindge linked an issue Jun 15, 2022 that may be closed by this pull request
@pindge pindge requested review from jeremyh and GypsyBojangles June 15, 2022 22:28
@pindge pindge marked this pull request as ready for review June 15, 2022 22:29
@pindge pindge marked this pull request as draft June 15, 2022 23:06
@pindge pindge requested a review from SpacemanPaul June 16, 2022 01:04
@pindge pindge marked this pull request as ready for review June 16, 2022 02:00
@pindge pindge changed the title make region code highest priority make explorer to record region_code in metadata as first preference Jun 16, 2022
Copy link
Collaborator

@jeremyh jeremyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pin. This sounds like a good idea now that ingested products are mostly defunct.

We'll need to mention on release that this change can make affected products inconsistent (summaries could exist with both old regions and new regions depending on when they were generated).

People will need to --force their summary update for those products to recreate all summaries consistently with the new regions.

@pindge
Copy link
Collaborator Author

pindge commented Jun 16, 2022

Thanks Pin. This sounds like a good idea now that ingested products are mostly defunct.

We'll need to mention on release that this change can make affected products inconsistent (summaries could exist with both old regions and new regions depending on when they were generated).

People will need to --force their summary update for those products to recreate all summaries consistently with the new regions.

noted!

@pindge pindge merged commit e4d2a48 into develop Jun 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-region-code branch June 16, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect tile numbers displayed for DEA C3 summary products
2 participants