Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display no matching region product with grey color in product selection #407

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

pindge
Copy link
Collaborator

@pindge pindge commented Jul 11, 2022

Fixes #57

Scope:

  • add a test case for checking the product selection menu while on the region page, only products containing the same region will display in white and every other product display in grey (indicating empty)
  • add product ls7_nbart_tmad_annual and one dataset sharing the same region_code as a dataset in ls5_nbart_tmad_annual
  • if on region pages, product selection will grey out all products without matching region_code
  • On any other page, only products with empty datasets will be greyed out.

image

@pindge pindge requested a review from jeremyh July 11, 2022 04:31
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #407 (8b08230) into develop (f20cdc9) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #407      +/-   ##
===========================================
+ Coverage    86.72%   86.76%   +0.04%     
===========================================
  Files           25       25              
  Lines         3148     3158      +10     
===========================================
+ Hits          2730     2740      +10     
  Misses         418      418              
Impacted Files Coverage Δ
cubedash/_pages.py 88.25% <100.00%> (+0.04%) ⬆️
cubedash/summary/_extents.py 91.90% <100.00%> (+0.16%) ⬆️
cubedash/summary/_stores.py 92.07% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20cdc9...8b08230. Read the comment docs.

Copy link
Collaborator

@jeremyh jeremyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pin, nice idea!

cubedash/summary/_extents.py Outdated Show resolved Hide resolved
cubedash/summary/_stores.py Outdated Show resolved Hide resolved
pindge and others added 2 commits July 11, 2022 15:18
@pindge pindge requested a review from jeremyh July 11, 2022 06:02
@pindge pindge added the UI/UX User interface issues label Jul 11, 2022
Copy link
Collaborator

@jeremyh jeremyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pin. We'll keep an eye on performance after deployment. If its too slow we should add an index.

@pindge pindge merged commit 2553873 into develop Jul 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the region-switch branch July 11, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX User interface issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User can navigate to regions that don't exist
2 participants