Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add localised time and utc time on tooltip #420

Merged
merged 4 commits into from
Aug 3, 2022
Merged

add localised time and utc time on tooltip #420

merged 4 commits into from
Aug 3, 2022

Conversation

pindge
Copy link
Collaborator

@pindge pindge commented Aug 3, 2022

fixes #419, #420

Scope

  • add tooltip for displaying time in UTC equiv
  • make search page for datasets display in local time
  • add flask app config for CUBEDASH_DEFAULT_TIMEZONE
  • add CUBEDASH_DEFAULT_TIMEZONE config to README
  • make center_time_from_metadata filter to always return time in default_utc
  • Change column name Time to Time (local) for clarity
  • add test case for checking both localised time and UTC time on tooltip

build fix

latest flask library is broken, pin to 2.1.3

Visual change

image

@pindge pindge requested a review from robbibt August 3, 2022 04:56
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #420 (727bc28) into develop (9ed9bcc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #420      +/-   ##
===========================================
+ Coverage    86.92%   86.94%   +0.02%     
===========================================
  Files           25       25              
  Lines         3158     3164       +6     
===========================================
+ Hits          2745     2751       +6     
  Misses         413      413              
Impacted Files Coverage Δ
cubedash/_filters.py 89.37% <100.00%> (+0.34%) ⬆️
cubedash/_model.py 94.16% <100.00%> (+0.04%) ⬆️
cubedash/_utils.py 87.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed9bcc...727bc28. Read the comment docs.

Copy link

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing @pindge, very exciting!

@pindge pindge merged commit 22a492b into develop Aug 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the ds-time branch August 3, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataset search page time not localised
2 participants