Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify docker build #455

Merged
merged 3 commits into from
Oct 27, 2022
Merged

simplify docker build #455

merged 3 commits into from
Oct 27, 2022

Conversation

pindge
Copy link
Collaborator

@pindge pindge commented Oct 18, 2022 •
edited
Loading

  • remove extra step for COPY and pip install

@pindge pindge marked this pull request as ready for review October 18, 2022 04:22
@codecov
Copy link

codecov bot commented Oct 18, 2022 •
edited
Loading

Codecov Report

Base: 86.61% // Head: 86.61% // No change to project coverage 👍

Coverage data is based on head (ff5f885) compared to base (b48b59e).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #455   +/-   ##
========================================
  Coverage    86.61%   86.61%           
========================================
  Files           23       23           
  Lines         3018     3018           
========================================
  Hits          2614     2614           
  Misses         404      404

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pindge pindge requested a review from whatnick October 18, 2022 21:29
jmettes
jmettes reviewed Oct 27, 2022
View reviewed changes
Dockerfile
@@ -63,10 +57,10 @@ ADD . $APPDIR
# then we want to link the source (with the -e flag) and if we're in prod, we
# want to delete the stuff in the /code folder to keep it simple.
RUN if [ "$ENVIRONMENT" = "deployment" ] ; then\
pip install .[$ENVIRONMENT] ; \
pip install .[$ENVIRONMENT] --extra-index-url https://packages.dea.ga.gov.au/; \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for an ODC repo to depend on DEA infra?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its being installed regardless, see requirement-docker.txt, this pr is simplify removing that .txt and put them together

@pindge pindge merged commit f405e56 into develop Oct 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the upgrade-cvs branch October 27, 2022 23:07
@jeremyh
Copy link
Collaborator

jeremyh commented Oct 31, 2022 •
edited
Loading

The advantage of two-step install was that code changes don't need a full rebuild of all dependencies.

Docker can cache the first step, containing all built dependencies.

Then code changes only need to rerun the (very fast) second step to update your container during development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmettes jmettes jmettes approved these changes

@SpacemanPaul SpacemanPaul Awaiting requested review from SpacemanPaul

@whatnick whatnick Awaiting requested review from whatnick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pindge @jeremyh @jmettes