-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataset thumbnail #487
Conversation
…r and updated broken readme link
This looks SO cool @Ariana-B, exactly what I had in mind! One question/suggestion: I can see in the code that it appears to only plot the thumbnail if it's from an NBART product. Would it be possible to generalise this to plot thumbnails for any product if they're available? For example, we also have thumbnails for most of our other Collection 3 products, and it'd be fantastic to be able to visualise them too. e.g. all of these (and more) have a "_thumbnail.jpg": https://data.dea.ga.gov.au/?prefix=derivative/ga_ls_fc_3/2-5-1/092/076/2018/06/17/ |
This is looking great Ariana. I was expecting it to require Python/Flask modifications as well as the template, hopefully the logic doesn't get too hairy by keeping it in the template with my next request. The DEA ARD data include thumbnails under the Eg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about moving the implementation out of the template and into a filter. See 👇 for details.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, thank you!
Thanks @Ariana-B! Super looking forward to seeing this go live - can someone tag me when that happens so I can test it out? |
Add image overlay to map if nbart thumbnail link is found.
Tested by running locally; seems to work as expected.
📚 Documentation preview 📚: https://datacube-explorer--487.org.readthedocs.build/en/487/