Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve image overlay #506

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Improve image overlay #506

merged 4 commits into from
Dec 6, 2022

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Dec 5, 2022

Determine image overlay bounds based on dataset bounds instead of extent for better overlap

image


📚 Documentation preview 📚: https://datacube-explorer--506.org.readthedocs.build/en/506/

@Ariana-B Ariana-B requested review from omad and robbibt December 5, 2022 06:17
Copy link

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! I'll do another closer review when it's live on Dev Explorer to see how it handles some weirder edge cases, but I think this should clear up most of the plotting issues for weird shaped geoms. Thanks @Ariana-B !

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 86.04% // Head: 86.05% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b0b4a8d) compared to base (bd72adf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #506      +/-   ##
===========================================
+ Coverage    86.04%   86.05%   +0.01%     
===========================================
  Files           24       24              
  Lines         3188     3192       +4     
===========================================
+ Hits          2743     2747       +4     
  Misses         445      445              
Impacted Files Coverage Δ
cubedash/_dataset.py 92.85% <ø> (ø)
cubedash/_utils.py 89.29% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ariana-B Ariana-B merged commit e09884a into develop Dec 6, 2022
@Ariana-B Ariana-B deleted the improve_thumbnail branch December 6, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants