Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update shapely version pin #512

Merged
merged 6 commits into from
Feb 5, 2023
Merged

update shapely version pin #512

merged 6 commits into from
Feb 5, 2023

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Feb 1, 2023

Pin shapely >= 2.0.0 to be compatible with datacube-core


📚 Documentation preview 📚: https://datacube-explorer--512.org.readthedocs.build/en/512/

omad and others added 5 commits February 3, 2023 10:45
Don't ask me why this is necessary now, I don't know. But it is.
Ariana and I have spent about 2 days each, beating our heads against the wall.
It ran fine before, it ran fine in a conda environment, it failed running in the docker-compose environment, it only failed intermittently when being debugged inside the docker-compose environment...
���
@omad omad force-pushed the fix_shapely_version branch from e681e62 to 6ff30cc Compare February 3, 2023 05:51
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 86.47% // Head: 86.48% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (767075c) compared to base (c0d206b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #512      +/-   ##
===========================================
+ Coverage    86.47%   86.48%   +0.01%     
===========================================
  Files           26       26              
  Lines         3430     3434       +4     
===========================================
+ Hits          2966     2970       +4     
  Misses         464      464              
Impacted Files Coverage Δ
cubedash/_audit.py 92.95% <ø> (ø)
cubedash/_dataset.py 92.85% <ø> (ø)
cubedash/_pages.py 88.03% <ø> (ø)
cubedash/summary/_extents.py 92.55% <ø> (ø)
cubedash/testutils/database.py 68.68% <ø> (ø)
cubedash/warmup.py 65.64% <ø> (ø)
cubedash/generate.py 85.16% <100.00%> (ø)
cubedash/summary/_stores.py 92.22% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic! ;-)

@omad omad merged commit dd4bd32 into develop Feb 5, 2023
@omad omad deleted the fix_shapely_version branch February 5, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants