Update to flask 3 #564
Merged
Update to flask 3 #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #564 +/- ##
===========================================
- Coverage 86.31% 86.29% -0.03%
===========================================
Files 26 26
Lines 3457 3451 -6
===========================================
- Hits 2984 2978 -6
Misses 473 473 ☔ View full report in Codecov by Sentry. |
pjonsson
force-pushed
the
flask-update
branch
from
d277131 to
ce81118
Compare
This decorator is deprecated in Flask 2.2. Remove the check for schema compatibility, generate.py already performs that check, and conftest.py ensures the tables are freshly created. Fixes opendatacube#547
This does not need to be pinned after removing the before_first_request decorator. The Werkzeug restriction was only added for the pinned flask, so remove that too. Werkzeug 3 has removed the safe_conversion parameter of iri_to_uri, so remove that from _stac_legacy.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the before_first_request decorator since it is deprecated in Flask 2.2.
Remove the check for schema compatibility,
generate.py already performs that check,
and conftest.py ensures the tables are
freshly created.
I don't know anything about Prometheus so I only know the CI tests pass,
I have no idea if Prometheus works as intended.
📚 Documentation preview 📚: https://datacube-explorer--564.org.readthedocs.build/en/564/