Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor wagl fixes #300

Merged
merged 2 commits into from
May 2, 2023
Merged

Minor wagl fixes #300

merged 2 commits into from
May 2, 2023

Conversation

jeremyh
Copy link
Collaborator

@jeremyh jeremyh commented May 2, 2023

A few more fixes that have caused some minor failures.

  • When no tesp doc was found by the wrapper, a variable was being referenced without initialisation, causing a python error.
  • NaN cloud values shouldn't override existing numbers. This NaNs would cause failures on a few datasets in downstream processing.

@jeremyh jeremyh requested a review from dunkgray May 2, 2023 00:04
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (17f80b6) 84.77% compared to head (0bcbff5) 84.78%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #300   +/-   ##
========================================
  Coverage    84.77%   84.78%           
========================================
  Files           26       26           
  Lines         4408     4410    +2     
========================================
+ Hits          3737     3739    +2     
  Misses         671      671           
Impacted Files Coverage Δ
eodatasets3/wagl.py 88.39% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeremyh jeremyh merged commit 0cdfa16 into opendatacube:develop May 2, 2023
@jeremyh jeremyh deleted the jez/minor-fixes branch May 2, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants