Fix lint, and replace black+isort+flake8 with Ruff #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruff seems well made, faset, and we've used it successfully in our other repos. Move this repo to use it too. Includes general clean-up.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #329 +/- ##
========================================
Coverage 84.39% 84.39%
========================================
Files 26 26
Lines 4504 4504
========================================
Hits 3801 3801
Misses 703 703 ☔ View full report in Codecov by Sentry. |
geoscience-aman
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint build didn't seem to be fully frozen, as it has started failing in develop.
We'll go ahead and replace the hybrid set of linting tools with Ruff.
Ruff seems well made, fast, and we've used it successfully in our other repos.
Includes other general clean-up.