Fix #181 #183 #184 #185
Fix #181 #183 #184 #185
Conversation
| @@ -107,13 +107,13 @@ def test_load_from_json_stackstac(fake_dask_client, bench_site1, bench_site2): | |||
| resampling="nearest", | |||
| extra={ | |||
| "odc-stac": {"groupby": "solar_day", "stac_cfg": CFG}, | |||
| "stackstac": {"dtype": "uint16", "fill_value": 0}, | |||
There was a problem hiding this comment.
can you explain why the change of dtype please?
There was a problem hiding this comment.
it significantly increases memory requirement (4 times)
There was a problem hiding this comment.
Hi @Kirill888 ,
It's because the uint16 values on stackstac don't support (anymore?) the fill_value=0 , so the easiest way to deal with that was to change to int64.
ValueError: The fill_value 0 is incompatible with the output dtype uint16. Either use `dtype='int64'`, or pick a different `fill_value`.
There was a problem hiding this comment.
what version of stackstac and numpy is that? My main concern here is that this change puts stackstac at disadvantage. Also this error looks to me like a numpy 2 upgrade issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #185 +/- ##
===========================================
+ Coverage 87.58% 91.54% +3.95%
===========================================
Files 23 24 +1
Lines 1982 2851 +869
===========================================
+ Hits 1736 2610 +874
+ Misses 246 241 -5 ☔ View full report in Codecov by Sentry. |
Kirill888
force-pushed
the
fixes
branch
2 times, most recently
from
a2442d3 to
f467fc6
Compare
add "numpy.typing.mypy_plugin" and python 3.10
There was a problem hiding this comment.
Thanks @nkarasiak it should all be working now
in the future, please use descriptive commit messages, and do not rely on the issue number alone.
Summary of the fix #IssueNumber
detailed description if needed
When trying to understand what changed it's really hard to remember which one is 181 which is 183 or 184.
|
Got it @Kirill888 , and thanks for educating me about how to enhance my fixes. |
Hi @Kirill888,
As suggested, I improved my pull request by providing 3 differents commits for the 3 differents issues that has been fixed.
You can take a look at it, it's way clearer now :)
Thanks !