Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Land Cover A3 Module #157

Closed
wants to merge 4 commits into from
Closed

Land Cover A3 Module #157

wants to merge 4 commits into from

Conversation

tebadi
Copy link
Contributor

@tebadi tebadi commented Oct 4, 2024

@tebadi tebadi requested review from emmaai and JM-GA October 4, 2024 03:21
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.50%. Comparing base (a504ed5) to head (070803b).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
odc/stats/plugins/lc_veg_bare_water_a3.py 95.12% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #157      +/-   ##
===========================================
+ Coverage    80.04%   80.50%   +0.46%     
===========================================
  Files           49       51       +2     
  Lines         4359     4483     +124     
===========================================
+ Hits          3489     3609     +120     
- Misses         870      874       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

@JM-GA JM-GA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tebadi Just a FYI - once the naming conventions are approved - we will likely need to rename some of the odc-stats modules - but this will be at a later date before we start bulk processing

Copy link
Contributor

@emmaai emmaai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you gather all this into plugins.lc_cevel3? I don't see a point of having another intermediate product. The final results can be produced in plugins.lc_level3 already. Also the sub-classes of level 4 are mutually exclusive, there is no need to have different bands anymore.

Copy link
Contributor

@emmaai emmaai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we agreed on the redundancy.

@tebadi tebadi closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants