-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipelines code #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quickly read the code. I didn't inspect in detail.
I'm approving because I think this is way more than enough for the PoC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments, suggestions, and questions inline, but it's looking good generally 👍
I wonder if some of the stuff in the pipelines
dir here should be either put into the acm/odh-core/
directory, or maybe alternatively a new application should be added to acm/registration/
repo, to get ACM to synchronize the cluster with what's defined here?
pipelines/containerfiles/Containerfile.openvino.mlserver.mlflow
Outdated
Show resolved
Hide resolved
pipelines/tekton/azureml-container-pipeline/azureml-container-pipeline.yaml
Outdated
Show resolved
Hide resolved
pipelines/tekton/test-mlflow-image-pipeline/test-mlflow-image-pipeline.yaml
Show resolved
Hide resolved
pipelines/tekton/azureml-container-pipeline/azureml-container-pipeline.yaml
Show resolved
Hide resolved
Co-authored-by: Gerard Ryan <gryan@redhat.com>
Co-authored-by: Gerard Ryan <gryan@redhat.com>
Description
Adds OpenShift Pipelines code to download a model from S3, build an image that uses that model, does some basic testing on the image, and uploads the image to Quay.
Also adds some documentation on how to use/deploy the pipeline code.
Resolves #2, resolves #4, resolves #1
How Has This Been Tested?
See
azureml-model-to-edge
project onlocal-cluster
, this is where I have tested and made sure all of this code works.Merge criteria: