Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipelines code #38

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Add pipelines code #38

merged 8 commits into from
Aug 29, 2023

Conversation

piotrpdev
Copy link
Member

@piotrpdev piotrpdev commented Aug 29, 2023

Description

Adds OpenShift Pipelines code to download a model from S3, build an image that uses that model, does some basic testing on the image, and uploads the image to Quay.

Also adds some documentation on how to use/deploy the pipeline code.

Resolves #2, resolves #4, resolves #1

How Has This Been Tested?

See azureml-model-to-edge project on local-cluster, this is where I have tested and made sure all of this code works.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@piotrpdev piotrpdev added kind/documentation Improvements or additions to documentation kind/enhancement New feature or request priority/high Important issue that needs to be resolved asap. Releases should not have too many o labels Aug 29, 2023
@piotrpdev piotrpdev added this to the Initial Edge PoC milestone Aug 29, 2023
@piotrpdev piotrpdev requested a review from LaVLaS August 29, 2023 17:41
@piotrpdev piotrpdev self-assigned this Aug 29, 2023
Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly read the code. I didn't inspect in detail.

I'm approving because I think this is way more than enough for the PoC.

Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments, suggestions, and questions inline, but it's looking good generally 👍

I wonder if some of the stuff in the pipelines dir here should be either put into the acm/odh-core/ directory, or maybe alternatively a new application should be added to acm/registration/ repo, to get ACM to synchronize the cluster with what's defined here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation kind/enhancement New feature or request priority/high Important issue that needs to be resolved asap. Releases should not have too many o
Projects
None yet
3 participants