Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifestst): remove empty CRD folder and reference #49

Closed
wants to merge 1 commit into from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Apr 7, 2024

fix code sync from upstream c771aae which is causing kustomize failing and ODH opeartor not functional

error:
Error: accumulating resources: accumulation err='accumulating resources from '../crd': '...../codeflare/crd' must resolve to a file': couldn't make target for path '.../codeflare/crd': kustomization.yaml is empty

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw
Copy link
Member Author

zdtsw commented Apr 7, 2024

@anishasthana / @dimakis we need fix for this, it is blocking operator PR tests and will be for odh-nightly too

Signed-off-by: Zhou, Wen <wenzhou@redhat.com>
Copy link

openshift-ci bot commented Apr 7, 2024

@zdtsw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 46ebf20 link false /test security
ci/prow/e2e-odh-cfo 46ebf20 link true /test e2e-odh-cfo

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anishasthana
Copy link
Member

Cc @dimakis @sutaakar @ChristianZaccaria can you look at this when you're on tomorrow? Looks like we have a CVE issue as well -- we will need to take these changes downstream too, to the right release branch.

@dimakis
Copy link

dimakis commented Apr 8, 2024

/approve

Copy link

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimakis, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member Author

zdtsw commented Apr 8, 2024

if we would like sync, can have this PR closed and get it from upstream project-codeflare#504

@dimakis dimakis closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants