Rebase from dspv1 main, Add v2undeploy command to Makefile #401

gmfrasca · 2023-10-17T20:11:55Z

Description of your changes:

Rebase from main (pull in CI fixes)
Adds v2undeploy command to Makefile

Testing instructions

make v2deploy, then make v2undeploy and ensure all dsp-v2 objects are cleaned up

Checklist

The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

Fix typo in README

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

Add gh workflow to auto add issues to proj.

Improved logs for deep comparisons in equalities.go

Added descriptive comments to DSPASpec

This adds a basic high level overview of what DSP is to the README

Add DSP overview to readme

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

…_1.5 Update 1.5 compatibility doc.

…info` as default. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>

…ty-doc-generate-1.5 Update DSP version compatibility doc.

Added argument to configure log levels for the operator and defined `…

- New image built to use go1.19

- io/ioutil is Deprecated as of Go 1.19, os now provides same functionality

Upgrade to Go 1.19

DharmitD

/lgtm

- Some components have conditions (only deploy if XYZ option set), so seperate these specific manifests from rest of the 'default ones for that component

dsp-developers · 2023-10-17T20:41:13Z

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-401

dsp-developers · 2023-10-17T21:02:40Z

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-401

- Fix duplicate key in v2/kustomization.yaml - Fix end-of-file newlines

dsp-developers · 2023-10-17T21:25:43Z

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-401

gregsheremeta · 2023-10-17T21:41:45Z

I reviewed the makefile change and just skimmed everything else

/lgtm
/approve

openshift-ci · 2023-10-17T21:41:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsheremeta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gregsheremeta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rkpattnaik780 and others added 21 commits September 20, 2023 11:25

Fix typo in README

a8df43f

Merge pull request opendatahub-io#350 from rkpattnaik780/readme_typo

3a183fa

Fix typo in README

Add gh workflow to auto add issues to proj.

7a06342

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

Merge pull request opendatahub-io#352 from HumairAK/add_to_proj_action

1a8be83

Add gh workflow to auto add issues to proj.

Improved logs for deep comparisons in equalities.go

b305b52

Merge pull request opendatahub-io#364 from hbelmiro/issue-318

8d99f77

Improved logs for deep comparisons in equalities.go

Added descriptions

a5ce575

Merge pull request opendatahub-io#360 from hbelmiro/issue-200

2fd3baa

Added descriptive comments to DSPASpec

Add DSP overview to readme

9763b1c

This adds a basic high level overview of what DSP is to the README

Merge pull request opendatahub-io#383 from accorvin/add-overview

aa2e0c9

Add DSP overview to readme

Update 1.5 compatibility doc.

fe74d65

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

Merge pull request opendatahub-io#386 from HumairAK/compatibility_doc…

ec1cb48

…_1.5 Update 1.5 compatibility doc.

Update DSPO to 1.5

6b7490a

Added argument to configure log levels for the operator and defined `…

c180c67

…info` as default. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>

Merge pull request opendatahub-io#388 from dsp-developers/compatibili…

5e305f7

…ty-doc-generate-1.5 Update DSP version compatibility doc.

Merge pull request opendatahub-io#385 from hbelmiro/issue-319

2098860

Added argument to configure log levels for the operator and defined `…

Upgrade to Go 1.19

5c786ad

Update precommit toolchain image ref

829f640

- New image built to use go1.19

GHAction: Mark source directory as safe for pre-commit

f21aa88

Update ioutil.ReadDir to os.ReadDir in testutil

66951c0

- io/ioutil is Deprecated as of Go 1.19, os now provides same functionality

Merge pull request opendatahub-io#396 from gmfrasca/upgrade-go-version

9925810

Upgrade to Go 1.19

openshift-ci bot requested review from amadhusu and gregsheremeta October 17, 2023 20:12

DharmitD reviewed Oct 17, 2023

View reviewed changes

openshift-ci bot assigned DharmitD Oct 17, 2023

openshift-ci bot added the lgtm label Oct 17, 2023

gmfrasca added 4 commits October 17, 2023 16:16

Add ApplyAll function

611b415

Add ApplyDir Reconciler function, Dynamically retrieve templates

88004d1

Handle subdirectories in GetTemplatesInDir util

7b4c1cb

Restructure Common Templates directory

2856b85

gmfrasca added 11 commits October 17, 2023 16:16

Restructure Object Storage templates directory

45ddc2c

Restructure components manifest directories with conditions

3f5e09f

- Some components have conditions (only deploy if XYZ option set), so seperate these specific manifests from rest of the 'default ones for that component

Add VisualizationServer and CRDViewer component manifests

b4f0ece

Add Reconcile Handlers for CRDViewer and VisualizationServer

3fcbb14

Fix Functional Tests (handle new envvars)

55774dc

Fix self-deployed DB/Storage missing secrets

bbd0aec

WIP: Add DSPv2 Internal Manifests

1aa8bb7

WIP: Implement v2deploy make command

3892ba5

Implement DSPVersion item in DSPA CRD

e21369a

Remove unneeded v2 kustomization params

bb82a91

Add v2undeploy command to Makefile

5594994

gmfrasca force-pushed the v2-continued branch from c275a9c to 5594994 Compare October 17, 2023 20:20

openshift-ci bot removed the lgtm label Oct 17, 2023

openshift-merge-robot added the needs-rebase label Oct 17, 2023

Merge branch 'dspv2' into v2-continued

e4b3f15

openshift-merge-robot removed the needs-rebase label Oct 17, 2023

gmfrasca changed the title ~~Add v2undeploy command to Makefile~~ Rebase from dspv1 mainl, Add v2undeploy command to Makefile Oct 17, 2023

gmfrasca changed the title ~~Rebase from dspv1 mainl, Add v2undeploy command to Makefile~~ Rebase from dspv1 main, Add v2undeploy command to Makefile Oct 17, 2023

Code formatting cleanliness updates

9700595

- Fix duplicate key in v2/kustomization.yaml - Fix end-of-file newlines

gmfrasca force-pushed the v2-continued branch from 0f5afa6 to 9700595 Compare October 17, 2023 21:21

gmfrasca mentioned this pull request Oct 17, 2023

Add data-science-pipelines- nameprefix to v2 RBAC manifests #403

Closed

3 tasks

openshift-ci bot assigned gregsheremeta Oct 17, 2023

openshift-ci bot added the lgtm label Oct 17, 2023

openshift-ci bot added the approved label Oct 17, 2023

openshift-ci bot merged commit e051c7f into opendatahub-io:dspv2 Oct 17, 2023
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase from dspv1 main, Add v2undeploy command to Makefile #401

Rebase from dspv1 main, Add v2undeploy command to Makefile #401

gmfrasca commented Oct 17, 2023 •

edited

Loading

DharmitD left a comment

dsp-developers commented Oct 17, 2023

dsp-developers commented Oct 17, 2023

dsp-developers commented Oct 17, 2023

gregsheremeta commented Oct 17, 2023 •

edited

Loading

openshift-ci bot commented Oct 17, 2023

Rebase from dspv1 main, Add v2undeploy command to Makefile #401

Rebase from dspv1 main, Add v2undeploy command to Makefile #401

Conversation

gmfrasca commented Oct 17, 2023 • edited Loading

Description of your changes:

Testing instructions

Checklist

DharmitD left a comment

Choose a reason for hiding this comment

dsp-developers commented Oct 17, 2023

dsp-developers commented Oct 17, 2023

dsp-developers commented Oct 17, 2023

gregsheremeta commented Oct 17, 2023 • edited Loading

openshift-ci bot commented Oct 17, 2023

gmfrasca commented Oct 17, 2023 •

edited

Loading

gregsheremeta commented Oct 17, 2023 •

edited

Loading