Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook RBAC and APIServer EnvVar updates #409

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Webhook RBAC and APIServer EnvVar updates #409

merged 2 commits into from
Oct 20, 2023

Conversation

gmfrasca
Copy link
Member

@gmfrasca gmfrasca commented Oct 19, 2023 •
edited by HumairAK
Loading

Resolves #379

Description of your changes:

  • Add MLMD GRPC Env Vars to APIServer if Defined
  • Update RBAC for webhook clusterroles:
    • Allow capability to delete mutating and validating webhook configurations CRs
    • Allow capability to CRUD finalizers on openshift-pipelines namespace

Testing instructions

Deploy v2 infra (make v2deploy), ensure webhooks do not have Permission Denied errors
Deploy DSPA with MLMD, ensure METADATA_GRPC_SERVICE_SERVICE_HOST and METADATA_GRPC_SERVICE_SERVICE_PORT are defined in the APIServer Deployment Environment Vars

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@gmfrasca
Update RBAC for webhook clusterroles
cefc24f 
- Allow capability to delete mutating and validating
  webhookconfigurations
- Allow capability to CRUD finalizers on openshift-pipelines namespace
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-409
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/409/head
git checkout -b pullrequest 945411241b7e325c9bd17762ec8ce7e871d0a404
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-409"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-409

rimolive
rimolive reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@rimolive rimolive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Part of #369

@openshift-ci openshift-ci bot added the lgtm label Oct 20, 2023
DharmitD
DharmitD approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Approve

Part of #379

@gmfrasca
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot removed the lgtm label Oct 20, 2023
@gmfrasca
Copy link
Member Author

/unhold

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-409

@HumairAK
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 7f762cc into opendatahub-io:dspv2 Oct 20, 2023
5 checks passed
@gmfrasca gmfrasca mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimolive rimolive rimolive left review comments

@HumairAK HumairAK HumairAK left review comments

@DharmitD DharmitD DharmitD approved these changes

Assignees

@rimolive rimolive

@HumairAK HumairAK

@DharmitD DharmitD

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gmfrasca @dsp-developers @HumairAK @rimolive @DharmitD