-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced kfdefs with DataScienceCluster resource and changed default ns to opendatahub #483
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/483/head
git checkout -b pullrequest 0b06b02b8398b108c0dff1319efbfb09dab70bf3
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-483" More instructions here on how to deploy and test a Data Science Pipelines Application. |
Change to PR detected. A new PR build was completed. |
1 similar comment
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
…ns to opendatahub Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Change to PR detected. A new PR build was completed. |
/approve |
/lgtm |
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Change to PR detected. A new PR build was completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amadhusu, DharmitD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/approve |
The issue resolved by this Pull Request:
Resolves #453
Description of your changes:
Replaced kfdefs with DataScienceCluster resource and changed default ns to opendatahub
Testing instructions
In a cluster with ODH Operator with 'fast' channel installed/ODH operator version > 2.0, create the following
DataScienceCluster
:The data-science-pipelines-operator should start successfully.
Checklist