Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced kfdefs with DataScienceCluster resource and changed default ns to opendatahub #483

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Nov 21, 2023

The issue resolved by this Pull Request:

Resolves #453

Description of your changes:

Replaced kfdefs with DataScienceCluster resource and changed default ns to opendatahub

Testing instructions

In a cluster with ODH Operator with 'fast' channel installed/ODH operator version > 2.0, create the following DataScienceCluster:

$ cat <<EOF | oc apply -f -
kind: DataScienceCluster
apiVersion: datasciencecluster.opendatahub.io/v1
metadata:
  name: data-science-pipelines-operator
  namespace: opendatahub
spec:
  components:
    dashboard:
      managementState: Managed
    datasciencepipelines:
      managementState: Managed
      devFlags:
        manifests:
          - uri: https://github.com/hbelmiro/data-science-pipelines-operator/tarball/issue-453
            contextDir: config
            sourcePath: base
EOF

The data-science-pipelines-operator should start successfully.

$ oc get pods -n opendatahub   
NAME                                                              READY   STATUS    RESTARTS   AGE
data-science-pipelines-operator-controller-manager-66b79b6lzrrz   1/1     Running   0          29s
odh-dashboard-f9c79d89b-k44pf                                     2/2     Running   0          33s
odh-dashboard-f9c79d89b-wz4xb                                     2/2     Running   0          33s

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-483
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/483/head
git checkout -b pullrequest 0b06b02b8398b108c0dff1319efbfb09dab70bf3
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-483"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-483

1 similar comment
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-483

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-483

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-483

…ns to opendatahub

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@hbelmiro hbelmiro changed the title WIP - Issue 453 Replaced kfdefs with DataScienceCluster resource and changed default ns to opendatahub Nov 23, 2023
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-483

@hbelmiro hbelmiro marked this pull request as ready for review November 23, 2023 18:11
@amadhusu
Copy link
Contributor

/approve

@amadhusu
Copy link
Contributor

/lgtm

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm label Nov 27, 2023
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-483

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Approve

Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 1, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 30e8efc into opendatahub-io:main Dec 1, 2023
5 checks passed
@hbelmiro hbelmiro deleted the issue-453 branch December 1, 2023 12:47
@amadhusu
Copy link
Contributor

amadhusu commented Dec 1, 2023

/approve

@hbelmiro hbelmiro mentioned this pull request Dec 19, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace kfdefs with DataScienceCluster resource and changer default ns to opendatahub for make deploy
4 participants