Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DSPO crashes when external connections failed #506

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

HumairAK
Copy link
Contributor

Resolve: #505

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-506
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/506/head
git checkout -b pullrequest 2ba42fbf18ab78c5620a73bcbab94b08b1da5679
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-506"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@amadhusu
Copy link
Contributor

/lgtm

@amadhusu
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amadhusu
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit 569d614 into opendatahub-io:main Dec 12, 2023
4 of 5 checks passed
@gmfrasca
Copy link
Member

related followup #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DSPO sometimes crashes when creating a DSPA due to minio endpoint connection failure
4 participants