Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values for v2 sample pipeline input parameters #517

Merged

Conversation

gmfrasca
Copy link
Member

The issue resolved by this Pull Request:

Resolves #personal annoyances :)

Description of your changes:

Add default values to the input parameters of the v2 sample pipeline such that they are auto-filled

Testing instructions

deploy DSPO. Create V2 DSPA, wait for it to be fully ready
Run the pre-loaded sample pipeline, verify that the input parameters (min_max_scaler=true, neighbors=3, standard_scalar=false)*

Note that standard_scalar seems to not pre-fill correctly, but this is due to a seperate bug (TODO: add link) where 'False' default values are simply not loaded.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-517
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/517/head
git checkout -b pullrequest 0fa3544a2a428ab6e627e5ccad0e050fdb9e7262
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-517"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@amadhusu
Copy link
Contributor

/lgtm

@HumairAK
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 88ae448 into opendatahub-io:dspv2 Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants