Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added samples for v2 and fixed v1 existing samples #541

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Added samples for v2 and fixed v1 existing samples #541

merged 2 commits into from
Feb 2, 2024

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Jan 12, 2024 •
edited
Loading

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-1710

Description of your changes:

This PR:

  • Moves config/samples/dspa_simple_v2.yaml to config/samples/v2
  • Creates one v2 equivalent sample for each of the existing v1 samples
  • Fixes samples that were not working

Testing instructions

  1. Deploy DSPO
  2. For each sample, deploy the DSPA and start a pipeline run. The pipeline must be completed successfully.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-541

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-541

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-541

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-541

@hbelmiro hbelmiro changed the title WIP - Issue 498 Added samples for v2 and fixed v1 existing samples Jan 19, 2024
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-541

@hbelmiro hbelmiro marked this pull request as ready for review January 19, 2024 18:38
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-541

@hbelmiro
Fixed samples and added new ones for v2
c77deba 
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@hbelmiro
Review
b9de476 
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-541

@openshift-ci openshift-ci bot added the lgtm label Jan 30, 2024
@HumairAK
Copy link
Contributor

HumairAK commented Feb 2, 2024

/lgtm
/approve

@HumairAK HumairAK merged commit fb34c43 into opendatahub-io:main Feb 2, 2024
5 of 6 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 2, 2024
@hbelmiro hbelmiro deleted the issue-498 branch February 5, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HumairAK HumairAK HumairAK left review comments

@gmfrasca gmfrasca gmfrasca left review comments

@amadhusu amadhusu amadhusu approved these changes

@gregsheremeta gregsheremeta Awaiting requested review from gregsheremeta

@VaniHaripriya VaniHaripriya Awaiting requested review from VaniHaripriya

Assignees

@HumairAK HumairAK

@amadhusu amadhusu

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hbelmiro @dsp-developers @HumairAK @gmfrasca @amadhusu @openshift-merge-robot