New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parameterize and upate argo v2 images. #549

Merged

HumairAK merged 1 commit into opendatahub-io:main from HumairAK:update_images

Jan 20, 2024

Contributor

HumairAK commented Jan 19, 2024 •

edited

Loading

Add an odh overlay to deploy argo + dspo together, to be utilized by a DSC
Parameterize argo images in argo pods
update image sources to point to v2 images
remove scheduled workflow crd from argo deployment (we already deploy it with dspo)
remove priority class from workflow controller because the ODH operator SA does not have permissions to deploy/set this.

is forbidden: no PriorityClass with name ds-pipelines-workflow-controller-priorityclass was found

openshift-ci bot requested review from gmfrasca and hbelmiro

January 19, 2024 22:03

Contributor

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

dsp-developers commented Jan 19, 2024

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-549
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/549/head
git checkout -b pullrequest d0cee33acc6440795ab3a1f424cb55ae80457c96
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-549"

More instructions here on how to deploy and test a Data Science Pipelines Application.

HumairAK force-pushed the update_images branch from d0cee33 to 38a67cf Compare

January 19, 2024 23:12

Contributor

dsp-developers commented Jan 19, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-549

HumairAK force-pushed the update_images branch from 38a67cf to f1f5bd7 Compare

January 19, 2024 23:24

Contributor

dsp-developers commented Jan 19, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-549

HumairAK force-pushed the update_images branch from f1f5bd7 to 79e95c7 Compare

January 19, 2024 23:35

Contributor

dsp-developers commented Jan 19, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-549

HumairAK force-pushed the update_images branch from 79e95c7 to 6126a2b Compare

January 20, 2024 18:16

Contributor

dsp-developers commented Jan 20, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-549

HumairAK force-pushed the update_images branch 2 times, most recently from d654929 to cdcab83 Compare

January 20, 2024 18:31

Contributor

dsp-developers commented Jan 20, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-549

HumairAK force-pushed the update_images branch from cdcab83 to 5e30bb2 Compare

January 20, 2024 18:47

Contributor

dsp-developers commented Jan 20, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-549

HumairAK force-pushed the update_images branch from 5e30bb2 to cbb4515 Compare

January 20, 2024 18:57

Contributor

dsp-developers commented Jan 20, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-549

HumairAK force-pushed the update_images branch from cbb4515 to d46943a Compare

January 20, 2024 19:10

Contributor

dsp-developers commented Jan 20, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-549

HumairAK force-pushed the update_images branch from d46943a to 3e85b6e Compare

January 20, 2024 19:17

Contributor

dsp-developers commented Jan 20, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-549


          parameterize and upate argo v2 images.

b2a21fe

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

HumairAK force-pushed the update_images branch from 3e85b6e to b2a21fe Compare

January 20, 2024 19:30

Contributor

dsp-developers commented Jan 20, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-549

HumairAK merged commit 3f5369f into opendatahub-io:main

5 of 6 checks passed

gmfrasca reviewed

View reviewed changes

Makefile

               		&& kustomize edit set namespace ${OPERATOR_NS}
               	kustomize build config/overlays/kind-tests | kubectl delete --ignore-not-found=$(ignore-not-found) -f -
+              .PHONY: deployODH

Member

gmfrasca Jan 22, 2024

we should document this (and the other deployment commands if they're not already in there) in the README

Contributor Author

HumairAK Jan 22, 2024

I think we can make this part of: https://issues.redhat.com/browse/RHOAIENG-1718

config/argo/kustomization.yaml

Comment on lines 19 to +20

               # - deployment.workflow-controller.yaml
-              - priorityclass.yaml
+              # - priorityclass.yaml

Member

gmfrasca Jan 22, 2024

we should remove these if they're not needed

Contributor Author

HumairAK Jan 22, 2024

yeah I wasn't sure, do you know the reasoning behind this one? I don't see why we would want this

config/base/params.env

+              IMAGES_MLMDENVOY=quay.io/opendatahub/ds-pipelines-metadata-envoy:v1.6.1
+              IMAGES_MLMDGRPC=quay.io/opendatahub/ds-pipelines-metadata-grpc:v1.6.1
+              IMAGES_MLMDWRITER=quay.io/opendatahub/ds-pipelines-metadata-writer:v1.6.1
+              IMAGES_CRDVIEWER=gcr.io/ml-pipeline/viewer-crd-controller:2.0.0-rc.2

Member

gmfrasca Jan 22, 2024

think we can remove this

config/samples/dspa_simple_v2.yaml

-                workflowController:
-                  deploy: true
-                  image: gcr.io/ml-pipeline/workflow-controller:v3.3.10-license-compliance
+                  image: quay.io/opendatahub/ds-pipelines-frontend:latest

Member

gmfrasca Jan 22, 2024

v1 and v2 frontend images are different, does this now point to the v2 frontend? does the v1 DSPA sample need to be updated?

Contributor Author

HumairAK Jan 22, 2024

you're right, it does need to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet