Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable kfp ui to retrieve artifacts. #550

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

HumairAK
Copy link
Contributor

This is a work around for the kfp ui to be able to read artifacts within the preview section. KFP UI will not accept port specifications for the s3 generic config, it will default to port 80 or 443 for http/https connections, since our default minio is port 80, we have to enable that port, as well as add the aws required s3 generic env vars to kfp ui deployment.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Copy link
Contributor

openshift-ci bot commented Jan 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-550
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/550/head
git checkout -b pullrequest efc481fc2fa940232aaa420a575f2fecb7b8fced
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-550"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK
Copy link
Contributor Author

Working in minio:
image

Working in aws s3 using external config:
image

@HumairAK HumairAK merged commit 368d935 into opendatahub-io:main Jan 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants