Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating NW Policy to have notebook pod connect to DSP APIServer #561

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Jan 30, 2024

The issue resolved by this Pull Request:

Resolves RHOAIENG-1689

Description of your changes:

Updating the DSPA network policy to have notebook pod connect to DSP APIServer, so that the notebook pods could connect to the DSP API Server without OAuth token interference.

Please refer to #556 for detailed comments and discussions.

Testing instructions

Deploy DSPO and a DSPA instance based on these changes.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-561
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/561/head
git checkout -b pullrequest 35a2fc28eda954fae9c72295ffe0ea5212cdc2d7
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-561"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK
Copy link
Contributor

HumairAK commented Feb 2, 2024

how did this policy end up in a folder named "tekton" (unrelated to the pr)? @DharmitD can you move this to the default folder? there is nothing tekton about this policy

@DharmitD
Copy link
Member Author

DharmitD commented Feb 2, 2024

how did this policy end up in a folder named "tekton" (unrelated to the pr)? @DharmitD can you move this to the default folder? there is nothing tekton about this policy

Done, moved the NetworkPolicy to the default folder.

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-561

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-561

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-561

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-561

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-561

@HumairAK
Copy link
Contributor

HumairAK commented Feb 9, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 9, 2024
@HumairAK HumairAK merged commit 38d1832 into opendatahub-io:main Feb 9, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants