-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating NW Policy to have notebook pod connect to DSP APIServer #561
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/561/head
git checkout -b pullrequest 35a2fc28eda954fae9c72295ffe0ea5212cdc2d7
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-561" More instructions here on how to deploy and test a Data Science Pipelines Application. |
how did this policy end up in a folder named "tekton" (unrelated to the pr)? @DharmitD can you move this to the |
Done, moved the NetworkPolicy to the |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves RHOAIENG-1689
Description of your changes:
Updating the DSPA network policy to have notebook pod connect to DSP APIServer, so that the notebook pods could connect to the DSP API Server without OAuth token interference.
Please refer to #556 for detailed comments and discussions.
Testing instructions
Deploy DSPO and a DSPA instance based on these changes.
Checklist