-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: argo network policy #570
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/570/head
git checkout -b pullrequest e921675f073cbfb5fd6421782687c06b226b699e
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-570" More instructions here on how to deploy and test a Data Science Pipelines Application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be isolated to my environment, but for some reason I am seeing that scheduledrun is failing with scheduledworkflow component throwing errors pasted below:
W0212 12:23:50.565554 1 reflector.go:424] pkg/mod/k8s.io/client-go@v0.25.3/tools/cache/reflector.go:169: failed to list *v1beta1.ScheduledWorkflow: json: cannot unmarshal string into Go struct field WorkflowResource.items.spec.workflow.spec of type v1beta1.PipelineRunSpec
E0212 12:23:50.565604 1 reflector.go:140] pkg/mod/k8s.io/client-go@v0.25.3/tools/cache/reflector.go:169: Failed to watch *v1beta1.ScheduledWorkflow: failed to list *v1beta1.ScheduledWorkflow: json: cannot unmarshal string into Go struct field WorkflowResource.items.spec.workflow.spec of type v1beta1.PipelineRunSpec
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
e921675
to
91d07ba
Compare
Change to PR detected. A new PR build was completed. |
Looks good now and all the tests passed |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amadhusu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves https://issues.redhat.com/browse/RHOAIENG-1711
Testing instructions