fix: argo network policy

[HumairAK]

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-1711

Testing instructions

• Deploy DSPO
• Deploy DSPA
• confirm you can:

1. Start a run
2. run completes, the completion green icon shows up (confirms persistent agent can talk to apiserver)
3. confirm a scheduled run is created and ran successfully (confirms scheduled workflow crd controller can talk to apiserver)
4. confirm artifacts/experiments updates (confirms mlmd communication)
5. confirm no errors in any of the pods
6. try to curl port 8443 and 8888 on the apiserver svc from outside the namespace in a different pod, 8443 should work, 8888 should not

[dsp-developers]

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-570
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/570/head
git checkout -b pullrequest e921675f073cbfb5fd6421782687c06b226b699e
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-570"

More instructions here on how to deploy and test a Data Science Pipelines Application.

[amadhusu]

Could be isolated to my environment, but for some reason I am seeing that scheduledrun is failing with scheduledworkflow component throwing errors pasted below:

W0212 12:23:50.565554 1 reflector.go:424] pkg/mod/k8s.io/client-go@v0.25.3/tools/cache/reflector.go:169: failed to list *v1beta1.ScheduledWorkflow: json: cannot unmarshal string into Go struct field WorkflowResource.items.spec.workflow.spec of type v1beta1.PipelineRunSpec
E0212 12:23:50.565604 1 reflector.go:140] pkg/mod/k8s.io/client-go@v0.25.3/tools/cache/reflector.go:169: Failed to watch *v1beta1.ScheduledWorkflow: failed to list *v1beta1.ScheduledWorkflow: json: cannot unmarshal string into Go struct field WorkflowResource.items.spec.workflow.spec of type v1beta1.PipelineRunSpec

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-570

[amadhusu]

Looks good now and all the tests passed
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amadhusu
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment