feat: Removed traces of argo server from default deployment. #587
Conversation
|
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/587/head
git checkout -b pullrequest 57db955658fe67d03316b61a4839c6e24bebea77
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-587"More instructions here on how to deploy and test a Data Science Pipelines Application. |
|
Change to PR detected. A new PR build was completed. |
|
Change to PR detected. A new PR build was completed. |
|
Change to PR detected. A new PR build was completed. |
|
Change to PR detected. A new PR build was completed. |
|
Change to PR detected. A new PR build was completed. |
amadhusu
changed the title
|
let's get at least 2 people to deploy this themselves and confirm it works before approving |
There was a problem hiding this comment.
@amadhusu ds-pipeline-workflow-controller-sample is failing as soon as deployed.
oc logs ds-pipeline-workflow-controller-sample-586c55b489-8xqxh
time="2024-03-07T12:51:49Z" level=info msg="index config" indexWorkflowSemaphoreKeys=true
time="2024-03-07T12:51:49Z" level=info msg="cron config" cronSyncPeriod=10s
time="2024-03-07T12:51:49Z" level=info msg="Memoization caches will be garbage-collected if they have not been hit after" gcAfterNotHitDuration=30s
time="2024-03-07T12:51:49.785Z" level=info msg="not enabling pprof debug endpoints"
time="2024-03-07T12:51:49.786Z" level=info msg="config map" name=ds-pipeline-workflow-controller-sample
time="2024-03-07T12:51:49.794Z" level=info msg="Get configmaps 200"
time="2024-03-07T12:51:49.798Z" level=info msg="Configuration:\nartifactRepository:\n archiveLogs: false\n s3:\n accessKeySecret:\n key: accesskey\n name: mlpipeline-minio-artifact\n bucket: mlpipeline\n endpoint: http://minio-sample.kubeflow.svc.cluster.local:9000\n insecure: false\n secretKeySecret:\n key: secretkey\n name: mlpipeline-minio-artifact\ncontainerRuntimeExecutor: emissary\nexecutor:\n imagePullPolicy: IfNotPresent\n name: \"\"\n resources: {}\ninitialDelay: 0s\nmetricsConfig: {}\nnodeEvents: {}\npodSpecLogStrategy: {}\ntelemetryConfig: {}\n"
time="2024-03-07T12:51:49.798Z" level=info msg="Persistence configuration disabled"
I0307 12:51:49.799153 1 leaderelection.go:248] attempting to acquire leader lease kubeflow/workflow-controller...
time="2024-03-07T12:51:49.802Z" level=info msg="Get leases 200"
time="2024-03-07T12:51:49.807Z" level=info msg="Update leases 200"
I0307 12:51:49.807676 1 leaderelection.go:258] successfully acquired lease kubeflow/workflow-controller
time="2024-03-07T12:51:49.807Z" level=info msg="new leader" leader=ds-pipeline-workflow-controller-sample-586c55b489-8xqxh
time="2024-03-07T12:51:49.807Z" level=info msg="Starting Workflow Controller" defaultRequeueTime=10s version=v3.3.10
time="2024-03-07T12:51:49.807Z" level=info msg="Current Worker Numbers" podCleanup=4 workflow=32 workflowTtl=4
time="2024-03-07T12:51:49.807Z" level=info msg="Watching task results" labelSelector="!workflows.argoproj.io/controller-instanceid,workflows.argoproj.io/workflow"
time="2024-03-07T12:51:49.807Z" level=info msg=Plugins executorPlugins=false
time="2024-03-07T12:51:49.809Z" level=info msg="List workflows 404"
time="2024-03-07T12:51:49.809Z" level=fatal msg="the server could not find the requested resource (get workflows.argoproj.io)"
@hbelmiro you need to ensure to do |
Sorry @amadhusu. I misunderstood it. /lgtm |
|
/lgtm |
Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
|
Change to PR detected. A new PR build was completed. |
|
nice work! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves RHOAIENG-3895
Description of your changes:
Removed the deployment files for argo server as it isn't required by default and it was the team's concensus as well in RHOAIENG-2873
Testing instructions
make deployODH IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-587"/config/samples/v2/dspa-simpleNOTE
If you deploy DSPO using
make deploy IMG="..., ensure to also domake argodeployas these will install all the CRDs,RBACs and whatnot required for argo workflow controller to workChecklist