-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow make deploy to fully deploy v2 stack #597
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/597/head
git checkout -b pullrequest 81e07625556d9ee06d88cccd7dc38b6119ec5a7b
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-597" More instructions here on how to deploy and test a Data Science Pipelines Application. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Change to PR detected. A new PR build was completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tested the same on my environment and it works well!
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amadhusu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
This pr fixes the broken
make deploy IMG=
option, and it also allowsmake deploy
to deploy the full v2 stack, including argo, eliminating the need fordeployODH
andargoDeploy
options.Testing instructions
run
make deploy
, andmake deploy IMG=<custom-image>
, and make sure they work as intended.Checklist