Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pipelines default pipeline store path #603

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Mar 14, 2024

Resolves: https://issues.redhat.com/browse/RHOAIENG-4509
for v2

Description of your changes:

Use the defaults provided via kfp for pipelines store path, also use the same log archive defaults.

For the pipelines, this setting ensure pipelines in obj store are organized under the pipelines folder in obj store, instead of the root (which would get messy).

Testing instructions

Confirm for both v1 and v2.

  1. Deploy a v1 dspa, upload a pipeline, confirm this pipeline is stored in the /pipelines folder in the object store
  2. you can do this by using the default minio, creating a route to minio, logging in (creds are in secrets) to the ui
  3. Do the same for v2 (in a new namespace, or clean up the existing one)

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-603
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/603/head
git checkout -b pullrequest 74868ebb89cc9b750d4e5e0ff07c873cb2055c85
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-603"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-603

Copy link
Contributor

@amadhusu amadhusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of the pipelines got stored underneath the pipelines directory instead of root directory.

DSPv2

Screenshot from 2024-03-15 19-36-12

DSPv1

Screenshot from 2024-03-15 19-47-09

Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amadhusu
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit 07b53bf into opendatahub-io:main Mar 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants