-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deploy mariadb nwp with mariadb #647
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/647/head
git checkout -b pullrequest 7ac94f5c0f01684f197543fedcdc99ede3f96533
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-647" More instructions here on how to deploy and test a Data Science Pipelines Application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm Just nit pick change- Please update networkpolicy name instead of newtorkpolicy
@VaniHaripriya the naming is consistent with the other files in the directory |
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
nvm I noticed the typo, updated |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Change to PR detected. A new PR build was completed. |
The issue resolved by this Pull Request:
Resolves https://issues.redhat.com/browse/RHOAIENG-5314
Description of your changes:
ensures the NWP is deployed along with mariadb, otherwise the DSPO will attempt to verify connection to mariadb without the nwp.
Checklist