Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - Update metadata envoy service name in mlpipelines-ui deployment file #653

Merged
merged 2 commits into from
May 22, 2024

Conversation

VaniHaripriya
Copy link
Contributor

@VaniHaripriya VaniHaripriya commented May 21, 2024

The issue resolved by this Pull Request:

Resolves RHOAIENG-5348

Description of your changes:

  • Updated mlpipelines-ui deployment file with the updated metadata-envoy service host .
  • Updated metadata-envoy-serviceaccount with the new service name.

Testing instructions

Created this PR to fix the below error in kfp-ui which was caused by the changes done with this PR-#650

Error occurred while trying to proxy request /ml_metadata.MetadataStoreService/GetContextByTypeAndName from ds-pipeline-ui-sample-dspa1.apps.rosa.hukhan.wrh7.p3.openshiftapps.com to http://ds-pipeline-metadata-envoy-sample:9090/ (ENOTFOUND) (https://nodejs.org/api/errors.html#errors_common_system_errors)

Deploy DSPO and create a DSPA instance. Create a pipeline run and make sure there are no errors in the UI and should be able to see the pipeline status.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from gmfrasca and rimolive May 21, 2024 20:44
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-653
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/653/head
git checkout -b pullrequest 819a6b93b818569cf1f75ac07db4e2af48f13ea6
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-653"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-653

Copy link
Member

@gmfrasca gmfrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Deployed and ran a pipeline successfully.

Screenshot from 2024-05-22 09-47-01

@HumairAK
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 69aa060 into opendatahub-io:main May 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants