-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX - Update metadata envoy service name in mlpipelines-ui deployment file #653
FIX - Update metadata envoy service name in mlpipelines-ui deployment file #653
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/653/head
git checkout -b pullrequest 819a6b93b818569cf1f75ac07db4e2af48f13ea6
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-653" More instructions here on how to deploy and test a Data Science Pipelines Application. |
Change to PR detected. A new PR build was completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro, HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves RHOAIENG-5348
Description of your changes:
Testing instructions
Created this PR to fix the below error in kfp-ui which was caused by the changes done with this PR-#650
Error occurred while trying to proxy request /ml_metadata.MetadataStoreService/GetContextByTypeAndName from ds-pipeline-ui-sample-dspa1.apps.rosa.hukhan.wrh7.p3.openshiftapps.com to http://ds-pipeline-metadata-envoy-sample:9090/ (ENOTFOUND) (https://nodejs.org/api/errors.html#errors_common_system_errors)
Deploy DSPO and create a DSPA instance. Create a pipeline run and make sure there are no errors in the UI and should be able to see the pipeline status.
Checklist