Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default envoy route behavior #687

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

HumairAK
Copy link
Contributor

envoy route should be enabled by default, unless specified otherwise via dspa CR

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-687
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/687/head
git checkout -b pullrequest 67fd52986faf381182dc6fb8148cae2345034109
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-687"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK
Copy link
Contributor Author

/hold

@HumairAK
Copy link
Contributor Author

/unhold

@HumairAK
Copy link
Contributor Author

see below for dspo + dashboard deployment, dspo using the image build from this pr, and dashboard from rhoai 2.11

pr-687

in this demo, the ds-project + pipeline server is provisioned via dashboard
as you can see, I am able to list executions/artifacts via dashboard

@rimolive
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit 25d21af into opendatahub-io:main Aug 16, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants