Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gitconfig to use --global option #475

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Nov 28, 2024

Reason for opening this PR: https://github.com/opendatahub-io/kubeflow/actions/runs/12071734972/job/33664140682

Follow up for: #469

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jiridanek and jstourac November 28, 2024 15:37
@jiridanek
Copy link
Member

The title does not match. The problem is that config must be set --globaly, it is not about order, right?

@jstourac
Copy link
Member

I would update the commit message and PR title also 🙃

/lgtm

@jiridanek
Copy link
Member

jiridanek commented Nov 28, 2024

Since there is only one git repo, maybe putting the nonglobal config after name: Checkout repository would (should?) work too. Guess that was the first thing tried?

@openshift-ci openshift-ci bot removed the lgtm label Nov 28, 2024
@atheo89 atheo89 changed the title Place gitconfig to right order otherwise it breaks Change gitconfig to use --global option Nov 28, 2024
@atheo89
Copy link
Member Author

atheo89 commented Nov 28, 2024

Thank you guys!

Copy link

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac
Copy link
Member

Since there is only one git repo, maybe putting the nonglobal config after name: Checkout repository would (should?) work too. Guess that was the first thing tried?

Yes, it was 🙂

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 28, 2024
@atheo89 atheo89 merged commit 65bef9f into opendatahub-io:main Nov 28, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants