Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from kubeflow:main #22

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Mar 8, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Copy link

openshift-ci bot commented Mar 8, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.43%. Comparing base (ece101a) to head (3e93a2c).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   76.43%   76.43%           
=======================================
  Files          17       17           
  Lines        2054     2054           
  Branches       74       74           
=======================================
  Hits         1570     1570           
  Misses        299      299           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/ok-to-test

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

only one scope of sync,
this will help us ensure proper Container Image tagging is in-place

/lgtm
/approve

Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pull[bot], tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5368a4d into opendatahub-io:main Mar 8, 2024
11 checks passed
rhods-devops-app bot pushed a commit to red-hat-data-services/model-registry that referenced this pull request Mar 13, 2024
* gitignore: ignore all coverage files

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>

* OAS: fix discriminator field for Artifact

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>

---------

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
rhods-devops-app bot pushed a commit to red-hat-data-services/model-registry that referenced this pull request Mar 13, 2024
* kubeflow: fix go module and odh. debranding (opendatahub-io#15)

* kubeflow: change go module name and references

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* kubeflow: rename odh. into kfmr.

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

* kubeflow: py: pyproject description

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

* kubeflow: nit picks in text documents

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Co-authored-by: tarilabs <matteo.mortari@gmail.com>

* Fix metadata OpenAPI spec (opendatahub-io#17)

* fix: OpenAPI metadata discriminator

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

* wiring factories and default values missed in codegen

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

* introduce openapi defaults

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

* fix TestMetadataValue*

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* fix: type assert generation

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* upgrade openapi spec version to v1alpha2

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: tarilabs <matteo.mortari@gmail.com>

* kubeflow: make MLMD type names (and prefix) pluggable (opendatahub-io#19)

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>

* build(deps): bump google.golang.org/grpc from 1.61.1 to 1.62.0 (opendatahub-io#20)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.1 to 1.62.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.61.1...v1.62.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* OAS: Fix discriminator field definition for Artifact (opendatahub-io#22)

* gitignore: ignore all coverage files

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>

* OAS: fix discriminator field for Artifact

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>

---------

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Isabella Basso <idoamara@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants