Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from kubeflow:main #23

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Mar 8, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

dependabot bot and others added 2 commits March 8, 2024 08:41
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.4...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

* Add first draft of model registry custom storage initializer

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Add documentation and get started guide

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Copy link

openshift-ci bot commented Mar 8, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (3e93a2c) to head (1bedfbd).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   76.43%   81.16%   +4.73%     
==========================================
  Files          17       12       -5     
  Lines        2054      600    -1454     
  Branches       74       74              
==========================================
- Hits         1570      487    -1083     
+ Misses        299       90     -209     
+ Partials      185       23     -162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

* fix: ensure consistency ns(omitted) for istio manifests

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>

* add default ns to kustomization for consistency

with manifests/kustomize/overlays/{db} kustomizations

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>

---------

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm label Mar 8, 2024
see also: https://security.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMCONTAINERDCONTAINERD-6219724

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/ok-to-test
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Mar 8, 2024
Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pull[bot], tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 37385f0 into opendatahub-io:main Mar 8, 2024
11 checks passed
@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/meow

Copy link

openshift-ci bot commented Mar 8, 2024

@tarilabs: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/honk

Copy link

openshift-ci bot commented Mar 8, 2024

@tarilabs:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/pony

Copy link

openshift-ci bot commented Mar 8, 2024

@tarilabs: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/shrug

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/unshrug

Copy link

openshift-ci bot commented Mar 8, 2024

@tarilabs: ¯\_(ツ)_/¯

In response to this:

/unshrug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/trickortreat
/joke

Copy link

openshift-ci bot commented Mar 8, 2024

@tarilabs: My cat was just sick on the carpet, I don’t think it’s feline well.

In response to this:

/trickortreat
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/trickortreat

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/woof
/this-is-fine

Copy link

openshift-ci bot commented Mar 8, 2024

@tarilabs: dog image

In response to this:

/woof
/this-is-fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

/this-is-fine

Copy link

openshift-ci bot commented Mar 8, 2024

@tarilabs: dog image

In response to this:

/this-is-fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucamolteni
Copy link

/pony

Copy link

openshift-ci bot commented Mar 8, 2024

@lucamolteni: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants