Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS file with adding more approvers #611

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Jul 9, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from atheo89 and caponetto July 9, 2024 12:16
@jiridanek jiridanek added the lgtm label Jul 9, 2024
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should first confirm with everyone if they all want this responsibility
before including this PR.

/hold

CONTRIBUTING.md Outdated Show resolved Hide resolved
@jstourac
Copy link
Member Author

At the moment, there are only the people who are explicitly okay with being approvers for this repository. Please, let me know in case anymore changes are necessary! 🙂

@jiridanek
Copy link
Member

/lgtm

@atheo89
Copy link
Member

atheo89 commented Jul 11, 2024

It's always good to have new ideas for improvements but I am not fully convinced yet.

I feel that each step of our process should have only the appropriate people, it doent's sound correct to have the same people in two consecutive steps. I mean obviously that could cause a degradation. The owners are the people that know the component almost from end to end, and they have a knowledge history of it.

I will bring an example,
Imagine to have a PR open from a contributor that re-introduce some things that are already covered by a feature long time ago, a member from our team likes this changes, imagine now another member that may review this pr and don't know the exact history assign also lgtm, so here, we can have two lgtm so any of these two people can allow a merge. In this scenario a merge could be fatal in our code base.

Also, even if the unit tests would be fully matured (which in our case they aren't) we could not just rely solely on them for approvals etc... So, maybe temporarily we will gain some time but i am afraid that we loose time later on chasing unexpected issues.

@jiridanek
Copy link
Member

/test images

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/unhold

thanks for the PR 💯
Kudos to the team for having more approvers

Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caponetto, harshad16, paulovmr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 205388b into opendatahub-io:main Jul 17, 2024
17 checks passed
@jstourac
Copy link
Member Author

Thank you, guys. I'll now backport the changes to other active branches in the upstream. Later in the downstream.

2024a seem to miss just this one commit, so lets do:

/cherrypick 2024a

@openshift-cherrypick-robot

@jstourac: only opendatahub-io org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

Thank you, guys. I'll now backport the changes to other active branches in the upstream. Later in the downstream.

2024a seem to miss just this one commit, so lets do:

/cherrypick 2024a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac
Copy link
Member Author

/cherrypick 2024a

@openshift-cherrypick-robot

@jstourac: new pull request created: #623

In response to this:

/cherrypick 2024a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants