-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OWNERS file with adding more approvers #611
Update OWNERS file with adding more approvers #611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should first confirm with everyone if they all want this responsibility
before including this PR.
/hold
At the moment, there are only the people who are explicitly okay with being approvers for this repository. Please, let me know in case anymore changes are necessary! 🙂 |
/lgtm |
It's always good to have new ideas for improvements but I am not fully convinced yet. I feel that each step of our process should have only the appropriate people, it doent's sound correct to have the same people in two consecutive steps. I mean obviously that could cause a degradation. The owners are the people that know the component almost from end to end, and they have a knowledge history of it. I will bring an example, Also, even if the unit tests would be fully matured (which in our case they aren't) we could not just rely solely on them for approvals etc... So, maybe temporarily we will gain some time but i am afraid that we loose time later on chasing unexpected issues. |
/test images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/unhold
thanks for the PR 💯
Kudos to the team for having more approvers
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caponetto, harshad16, paulovmr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
205388b
into
opendatahub-io:main
Thank you, guys. I'll now backport the changes to other active branches in the upstream. Later in the downstream. 2024a seem to miss just this one commit, so lets do: /cherrypick 2024a |
@jstourac: only opendatahub-io org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick 2024a |
@jstourac: new pull request created: #623 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.