Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use a smarter git status check for uncommitted files #612

Merged

Conversation

jiridanek
Copy link
Member

Description

This is stolen from a recent kubeflow PR by @ederign. Compared to the previous version, this also reports on new untracked files. Also, the command is much simpler to read.

How Has This Been Tested?

See GHA results.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

This is stolen from a recent kubeflow PR by @ederign. Compared to the previous version, this also reports on new untracked files. Also, the command is much simpler to read.
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: caponetto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 19654a3 into opendatahub-io:main Jul 10, 2024
6 checks passed
@jiridanek jiridanek deleted the jd_2024_07_09_check_diff branch July 10, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants