Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-1751: Bump jinja2 lib to 3.1.4 #613

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

paulovmr
Copy link
Contributor

@paulovmr paulovmr commented Jul 9, 2024

Description

Bump jinja2 lib to 3.1.4 as suggested by Snyk. Updated necessary lock files.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and jstourac July 9, 2024 19:32
@jiridanek
Copy link
Member

let's see if this works

/label trivy-scan

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@jiridanek: The label(s) /label trivy-scan cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

let's see if this works

/label trivy-scan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek jiridanek added the trivy-scan This label that allows trivy to create a security report on the pull requests label Jul 10, 2024
@jiridanek jiridanek closed this Jul 10, 2024
@jiridanek jiridanek reopened this Jul 10, 2024
@@ -27,7 +27,7 @@ mysql-connector-python = "~=8.3.0"
ipykernel = "==6.13.0"
ipython = "==8.10.0"
ipython-genutils = "==0.2.0"
jinja2 = "==3.0.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivy does not complain about this on regular scheduled scans. It does see the package, https://github.com/opendatahub-io/notebooks/actions/runs/9867254845/job/27247380483#step:14:77, but it is not mentioned in https://github.com/opendatahub-io/notebooks/actions/runs/9867254845#summary-27247380483. I'm willing to guess that's because the severity of the cve is too low to show on the final report.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this one is a MEDIUM. If it is more helpful, we can allow all severities in the daily report.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal is to allow comparing PR report and daily report to check cve went away, then all severities in all reports would need to be displayed.

Or we can say that we mostly fix the HIGH and CRITICAL stuff, so it's enough to show that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, I thought that we were focusing only on HIGH and CRITICAL issues but, given these PRs, I would enable all types of severity on the daily report too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiridanek
Copy link
Member

/override ci/prow/intel-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override ci/prow/intel-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@paulovmr
Copy link
Contributor Author

/retest

@caponetto
Copy link
Contributor

caponetto commented Jul 10, 2024

I see the same failure (ci/prow/intel-notebooks-e2e-tests) on my PR (#608) so it is likely unrelated.

@jiridanek
Copy link
Member

@atheo89
Copy link
Member

atheo89 commented Jul 11, 2024

Thanks Paulo for the upgrade!

/lgtm
/approve
/override ci/prow/intel-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/intel-notebooks-e2e-tests

In response to this:

Thanks Paulo for the upgrade!

/lgtm
/approve
/override ci/prow/intel-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0cb7484 into opendatahub-io:main Jul 11, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm trivy-scan This label that allows trivy to create a security report on the pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants