Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Sanitize ref name before using it as container tag #651

Merged

Conversation

caponetto
Copy link
Contributor

Description

This PR fixes the CI errors we are seeing on dependabot PRs. As the ref name is used to compose the image tag, it cannot be used directly since it can contain invalid chars for the image tag.

How Has This Been Tested?

Run the workflow with these changes

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and dibryant July 31, 2024 09:52
@caponetto caponetto changed the title Sanitize ref name before using it as container tag chore(ci): Sanitize ref name before using it as container tag Jul 31, 2024
@jstourac
Copy link
Member

/lgm

@jiridanek
Copy link
Member

/lgtm

Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caponetto
Copy link
Contributor Author

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

@caponetto: Overrode contexts on behalf of caponetto: ci/prow/images, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@harshad16
Copy link
Member

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 4520c93 into opendatahub-io:main Jul 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants