Modify Regular Expression for the support of tag suffix with latest/fast #202
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rpancham The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: rpancham <rpancham@redhat.com>
| @@ -66,7 +66,7 @@ jobs: | |||
|
|
|||
| - name: Update params.env with new release version | |||
| run: | | |||
| sed -i 's|:v[0-9.]*\b|:${{ github.event.inputs.tag_name }}|gm' config/base/params.env | |||
| sed -i 's|:v[0-9.]*.*|:${{ github.event.inputs.tag_name }}|gm' config/base/params.env | |||
There was a problem hiding this comment.
fast or latest does not start with v.
is this correct?
There was a problem hiding this comment.
Yes, it doesn't start with v , On the release branches we will be having the tag starting with v but for the first release we will be having it has fast or latest so yesterday it was decided that for the tag we will be prefixing the version.
@israel-hdez please can you confirm
There was a problem hiding this comment.
My understanding is that this new workflow would only be ran against release-* branches, not in main branch.
So, as part of our branch cut, we should modify params.env file to use v{something} tags. Ex: https://github.com/opendatahub-io/odh-model-controller/blob/release-0.11.1/config/base/params.env. Thus, the regex would match for release-* branches, which seems to be what we need.
There was a problem hiding this comment.
That sounds good, asked because the PR title confused me.
|
/lgtm |
What this PR does / why we need it:
Automate ODH Release Process for Kserve repos
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #RHOAIENG-2732