Adding JSON files for Prometheus queries for Runtimes. #209
Conversation
|
@alexcreasy could you take a look at this PR and lgtm purely in terms of the structure of the json files and ensuring that it looks like what has been discussed. |
| @@ -0,0 +1,55 @@ | |||
| { | |||
| "metrics": { | |||
| "supported": true, | |||
There was a problem hiding this comment.
@VedantMahabaleshwarkar you mentioned this needed to be a string value rather than a boolean for technical reasons - is that the case? The dashboard is currently looking for string "true" || "false".
There was a problem hiding this comment.
Hi Alex, updated the bool to be a string in the second commit! It was an oversight on my part. Apologies.
| ] | ||
| }, | ||
| { | ||
| "title": "Memory usage over a range of time per model deployment", |
There was a problem hiding this comment.
@VedantMahabaleshwarkar Have you got these titles OK'd with UXD? They look extremely long and if we're moving to a model of displaying these strings directly in the dashboard they have to be approved.
This point doesn't need to hold up this PR but it's something that will need to be taken care of before it can be signed off.
There was a problem hiding this comment.
Hi Alex, matched the titles to those that would be displayed by modelmesh in the second commit. Let me know if this is more suitable!
Signed-off-by: Killian Golds <kgolds@redhat.com> Updated Query titles and fixed Memory Utilization metric query.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KillianGolds, VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
RHOAIENG-7353
RHOAIENG-3052
Prereq for #204
How Has This Been Tested?
I tested each query against a deployment of each runtime mentioned in the commits. To ensure the correct metric is returned.
Merge criteria: