Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update params.env with caikit image #226

Conversation

christinaexyou
Copy link
Contributor

Updates config/base/params.env by adding the Caikit Standalone image.

Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

Hi @christinaexyou. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@heyselbi
Copy link
Contributor

/ok-to-test

@heyselbi
Copy link
Contributor

@christinaexyou it should be image in quay.io/opendatahub

@heyselbi
Copy link
Contributor

Please update it to
quay.io/opendatahub/caikit-nlp:stable-994ec60
@christinaexyou

Signed-off-by: Christina Xu <chrxu@redhat.com>
@heyselbi
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christinaexyou, heyselbi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5165fb5 into opendatahub-io:release-0.12.0 Jun 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants