-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Compatibility Matrix #140
Conversation
Hi @wallashss. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a8eb62c
to
ee1ddfd
Compare
282dbff
to
5609071
Compare
How about proposing this upstream instead? |
Co-authored-by: Yan Ma <yan.ma@intel.com>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
…ting type annotations (vllm-project#8490)
Signed-off-by: Wallas Santos <wallashss@ibm.com>
5609071
to
e72169b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wallashss The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed to upstream: |
* Per @iotamudelta suggestion until the deadlocks issue is better understood Revert "Make CAR ROCm 6.1 compatible. (opendatahub-io#137)" This reverts commit 4d2dda6. * Per @iotamudelta suggestion until the deadlocks issue is better understood Revert "Optimize custom all reduce (opendatahub-io#130)" This reverts commit 636ff01.
This PR add as documentation a compatibility matrix for mutual exclusive features of vllm
The table bellow shows is a mirror, its purpose is to ease the curation of the table to help double check the incompatible combined features. IMO the cleaner version looks better in the final documentation.